Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [okx] support Unsubscription and Resubscription #1496

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 313 BBG.

@bailantaotao bailantaotao force-pushed the edwin/pkx/fix-sub-events branch from 2a4f6c0 to a7aa34c Compare January 10, 2024 06:07
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 326 BBG

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (08fa1e9) 21.61% compared to head (a7aa34c) 21.59%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   21.61%   21.59%   -0.02%     
==========================================
  Files         602      602              
  Lines       44081    44115      +34     
==========================================
  Hits         9527     9527              
- Misses      33859    33893      +34     
  Partials      695      695              
Files Coverage Δ
pkg/types/stream.go 0.00% <ø> (ø)
pkg/exchange/okex/parse.go 64.51% <0.00%> (-0.53%) ⬇️
pkg/exchange/okex/convert.go 0.86% <0.00%> (-0.02%) ⬇️
pkg/exchange/okex/stream.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fa1e9...a7aa34c. Read the comment docs.

@bailantaotao bailantaotao changed the title FEATURE: support Unsubscription and Resubscription FEATURE: [okx] support Unsubscription and Resubscription Jan 10, 2024
@bailantaotao bailantaotao merged commit 9da9130 into main Jan 10, 2024
@bailantaotao bailantaotao deleted the edwin/pkx/fix-sub-events branch January 10, 2024 12:49
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 336 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xfe195b386fb8ae33718a7250d9a07ddbb10711bdab35611643d065cc0191be49

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants